Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CH 31 Form Send to RES #16363

Merged
merged 31 commits into from
May 30, 2024
Merged

CH 31 Form Send to RES #16363

merged 31 commits into from
May 30, 2024

Conversation

tfink419
Copy link
Contributor

@tfink419 tfink419 commented Apr 16, 2024 •
edited
Loading

Summary

  • This work is behind a feature toggle (flipper): YES veteran_readiness_employment_to_res
  • Redirect ch31 form from VRE service to RES service

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Have tested in staging/sandbox environments with code in console

What areas of the site does it impact?

Backend only redirect to new service to handle same form

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@va-vsp-bot
Copy link
Collaborator

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: lib/res/ch31_form.rb

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 16, 2024 •
edited
Loading

1 Warning
⚠️ This PR changes 466 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding
200. Expect some delays getting reviews.

File Summary

Files

  • .github/CODEOWNERS (+2/-0)

  • app/models/saved_claim/veteran_readiness_employment_claim.rb (+68/-36)

  • app/sidekiq/vre/submit1900_job.rb (+3/-3)

  • config/features.yml (+4/-0)

  • config/settings.yml (+4/-0)

  • config/settings/test.yml (+4/-0)

  • lib/res/ch31_form.rb (+135/-0)

  • lib/res/configuration.rb (+30/-0)

  • lib/res/errors/ch31_errors.rb (+4/-0)

  • lib/res/service.rb (+34/-0)

  • spec/lib/res/ch31_form_spec.rb (+60/-0)

  • spec/models/saved_claim/veteran_readiness_employment_claim_spec.rb (+27/-49)

  • spec/sidekiq/vre/submit1900_job_spec.rb (+2/-1)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

@va-vfs-bot va-vfs-bot temporarily deployed to ch31-submission-to-res-65386/main/main April 16, 2024 17:45 Inactive
@va-vsp-bot
Copy link
Collaborator

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: lib/res/ch31_form.rb

@va-vfs-bot va-vfs-bot temporarily deployed to ch31-submission-to-res-65386/main/main April 17, 2024 17:54 Inactive
@va-vsp-bot
Copy link
Collaborator

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: lib/res/ch31_form.rb

@va-vsp-bot
Copy link
Collaborator

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: lib/res/ch31_form.rb

@va-vfs-bot va-vfs-bot temporarily deployed to ch31-submission-to-res-65386/main/main April 24, 2024 23:13 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to ch31-submission-to-res-65386/main/main April 25, 2024 17:48 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to ch31-submission-to-res-65386/main/main May 14, 2024 19:00 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to ch31-submission-to-res-65386/main/main May 29, 2024 20:40 Inactive
@tfink419 tfink419 marked this pull request as ready for review May 29, 2024 20:40
@tfink419 tfink419 requested review from a team as code owners May 29, 2024 20:41
micahaspyr
micahaspyr previously approved these changes May 29, 2024
View reviewed changes
@va-vfs-bot va-vfs-bot temporarily deployed to ch31-submission-to-res-65386/main/main May 29, 2024 21:50 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to ch31-submission-to-res-65386/main/main May 30, 2024 02:03 Inactive
tblackwe
tblackwe reviewed May 30, 2024
View reviewed changes
app/models/saved_claim/veteran_readiness_employment_claim.rb Outdated Show resolved Hide resolved
lib/res/ch31_form.rb Outdated Show resolved Hide resolved
tblackwe
tblackwe reviewed May 30, 2024
View reviewed changes
lib/res/ch31_form.rb Outdated Show resolved Hide resolved
@va-vfs-bot va-vfs-bot temporarily deployed to ch31-submission-to-res-65386/main/main May 30, 2024 17:21 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to ch31-submission-to-res-65386/main/main May 30, 2024 17:31 Inactive
@platform-support-slack-integration platform-support-slack-integration bot mentioned this pull request May 30, 2024
Closed
@tfink419 tfink419 merged commit 3d1a9a2 into master May 30, 2024
19 checks passed
@tfink419 tfink419 deleted the ch31-submission-to-res-65386 branch May 30, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tblackwe tblackwe tblackwe approved these changes

@micahaspyr micahaspyr micahaspyr approved these changes

@ericboehs ericboehs ericboehs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tfink419 @va-vsp-bot @ericboehs @micahaspyr @tblackwe @va-vfs-bot